Skip to content

Bump golangci-lint to 2.7.2 for watcher #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Jan 7, 2026
Merged

Bump golangci-lint to 2.7.2 for watcher #321

openshift-merge-bot merged 1 commit into from
Jan 7, 2026
+2 −2

Conversation

@dprince
Copy link
Contributor

@dprince dprince commented Dec 19, 2025

Summary

-Bump golangci-lint to 2.7.2

@openshift-ci openshift-ci bot requested review from raukadah and stuggi December 19, 2025 18:30
@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Dec 19, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8b01352e36754af8802700d51eaba971

✔️ openstack-meta-content-provider-master SUCCESS in 3h 58m 04s
✔️ watcher-operator-validation-master SUCCESS in 1h 59m 16s
✔️ openstack-meta-content-provider-epoxy SUCCESS in 3h 52m 23s
❌ watcher-operator-validation-epoxy FAILURE in 1h 49m 33s
✔️ watcher-operator-validation-epoxy-ocp4-16 SUCCESS in 1h 53m 29s
✔️ noop SUCCESS in 0s
✔️ watcher-operator-kuttl SUCCESS in 51m 57s

@cescgina
Copy link
Contributor

cescgina commented Dec 22, 2025

recheck

@cescgina
Copy link
Contributor

cescgina commented Dec 22, 2025

/approve

CI seems happy with the bump

@openshift-ci
Copy link

openshift-ci bot commented Dec 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cescgina

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

stuggi
stuggi reviewed Jan 5, 2026
View reviewed changes
Makefile
cd ./api && go mod tidy

GOLANGCI_LINT_VERSION ?= v2.4.0
GOLANGCI_LINT_VERSION ?= v2.7.2
Copy link
Contributor

@stuggi stuggi Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about https://github.com/openstack-k8s-operators/watcher-operator/blob/main/.pre-commit-config.yaml#L82 ?

Copy link
Contributor Author

@dprince dprince Jan 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call. They were different versions so my replacement didn't catch it. I fixed it.

@dprince dprince force-pushed the golang_ci_lint_bump branch from ca7f06a to 582f428 Compare January 5, 2026 19:39
stuggi
stuggi approved these changes Jan 7, 2026
View reviewed changes
Copy link
Contributor

@stuggi stuggi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 7, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit 486f434 into openstack-k8s-operators:main Jan 7, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuggi stuggi stuggi approved these changes

@raukadah raukadah Awaiting requested review from raukadah

Assignees

@stuggi stuggi

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dprince @cescgina @stuggi